Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch python deps for oiffile #231

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Patch python deps for oiffile #231

wants to merge 1 commit into from

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Feb 24, 2022 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@goanpeca goanpeca mentioned this pull request Feb 24, 2022
Merged
9 tasks
@goanpeca
Copy link
Member Author

Required by:

@goanpeca
Copy link
Member Author

goanpeca commented Feb 24, 2022 •
edited
Loading

@jaimergp could you review this PR :)

============================= test session starts ==============================
platform linux -- Python 3.10.2, pytest-7.0.1, pluggy-1.0.0 -- $PREFIX/bin/python
cachedir: .pytest_cache
rootdir: $SRC_DIR
collecting ... collected 2 items

test_gen_patch_json.py::test_gen_patch_instructions PASSED               [ 50%]
test_gen_patch_json.py::test_add_python_abi PASSED                       [100%]

============================== 2 passed in 0.39s ===============================
+ python show_diff.py
Downloading: https://conda.anaconda.org/conda-forge/noarch/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/noarch/repodata.json.bz2
noarch::oiffile-2021.6.6-pyhd8ed1ab_0.tar.bz2
-    "python >=3.7",
+    "python >=3.8",
noarch::oiffile-2022.2.2-pyhd8ed1ab_0.tar.bz2
-    "python >=3.7",
+    "python >=3.8",
Downloading: https://conda.anaconda.org/conda-forge/linux-64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-64/repodata.json.bz2

Thanks!

@jaimergp
Copy link
Member

I would maybe add a timestamp check too, like in the record above @goanpeca

@goanpeca
Copy link
Member Author

Sounds good! thanks :)

@goanpeca goanpeca mentioned this pull request Apr 27, 2022
Merged
@hmaarrfk
Copy link
Contributor

Is this PR still relevant 2.5 years later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goanpeca @conda-forge-linter @jaimergp @hmaarrfk